[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: AC_TRY_COMPILE() annoyances with 2.63b
From: |
Mike Frysinger |
Subject: |
Re: AC_TRY_COMPILE() annoyances with 2.63b |
Date: |
Mon, 6 Apr 2009 17:43:30 -0400 |
User-agent: |
KMail/1.11.1 (Linux/2.6.28; KDE/4.2.1; x86_64; ; ) |
On Monday 06 April 2009 14:09:29 Ralf Wildenhues wrote:
> Hello Mike, Eric,
>
> * Mike Frysinger wrote on Mon, Apr 06, 2009 at 03:16:53PM CEST:
> > --- a/lib/m4sugar/m4sh.m4
> > +++ b/lib/m4sugar/m4sh.m4
> > @@ -607,7 +607,7 @@ m4_define([_AS_IF],
> > ])
> > m4_define([_AS_IF_ELSE],
> > [m4_ifvaln([$1],
> > -[else
> > +[else :
> > $1])])
> >
> > m4_defun([AS_IF],
>
> I like this one, for simplicity and obvious correctness alone, but will
> defer to Eric for the final decision.
personally, i prefer both :). dont emit extraneous brackets when they arent
needed, and be safe when we think we must.
> Question is whether the "then"
> and "elif" parts should receive the same treatment.
if Eric is ok with this change, i can submit a "proper" one with those changed
as well.
> BTW, m4_normalize would have been wrong as it can change expanded text
> that you wouldn't want changed, too. (I think.)
but that wouldnt matter would it ? we're only expanding to check it
ifvaln(normalize($1)). if we like the result, then we emit $1 as part of the
else. but again, m4 subtleties are beyond me.
-mike
signature.asc
Description: This is a digitally signed message part.
- AC_TRY_COMPILE() annoyances with 2.63b, Mike Frysinger, 2009/04/05
- Re: AC_TRY_COMPILE() annoyances with 2.63b, Eric Blake, 2009/04/05
- Re: AC_TRY_COMPILE() annoyances with 2.63b, Mike Frysinger, 2009/04/05
- Re: AC_TRY_COMPILE() annoyances with 2.63b, Mike Frysinger, 2009/04/05
- Re: AC_TRY_COMPILE() annoyances with 2.63b, Eric Blake, 2009/04/06
- Re: AC_TRY_COMPILE() annoyances with 2.63b, Mike Frysinger, 2009/04/06
- Re: AC_TRY_COMPILE() annoyances with 2.63b, Ralf Wildenhues, 2009/04/06
- Re: AC_TRY_COMPILE() annoyances with 2.63b,
Mike Frysinger <=
- Re: AC_TRY_COMPILE() annoyances with 2.63b, Eric Blake, 2009/04/06
- Re: AC_TRY_COMPILE() annoyances with 2.63b, Ralf Wildenhues, 2009/04/07
- Re: AC_TRY_COMPILE() annoyances with 2.63b, Ralf Wildenhues, 2009/04/07
- Re: AC_TRY_COMPILE() annoyances with 2.63b, Mike Frysinger, 2009/04/07
- Re: AC_TRY_COMPILE() annoyances with 2.63b, Andreas Schwab, 2009/04/07
- AS_IF optimization (was: AC_TRY_COMPILE() annoyances with 2.63b), Eric Blake, 2009/04/07
- Re: AS_IF optimization (was: AC_TRY_COMPILE() annoyances with 2.63b), Andreas Schwab, 2009/04/07
- Re: AS_IF optimization, Eric Blake, 2009/04/07
- Re: AS_IF optimization, Eric Blake, 2009/04/10
- Re: AC_TRY_COMPILE() annoyances with 2.63b, Eric Blake, 2009/04/10