[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: allow convenient library in subdirectory
From: |
Tom Tromey |
Subject: |
Re: allow convenient library in subdirectory |
Date: |
18 Jul 2001 19:30:33 -0600 |
>>>>> "adl" == Alexandre Duret-Lutz <address@hidden> writes:
adl> Ok, second try.
This looks good. I have a couple small nits (sorry).
adl> - push (@dep_list, $directory . '/.dirstamp');
adl> + push (@dep_list, &require_build_directory ($directory));
Since &require_build_directory returns the empty string, I think we
should remove empty elements from @dep_list before using it...
adl> &pretty_print_rule ($object . ':', "\t", @dep_list)
...you can do that here using grep.
adl> + # If the resulting library lies into a subdirectory,
adl> + # make sure this directory will exist.
adl> + my $dirstamp = &require_build_directory_maybe ($onelib);
adl> +
adl> $output_rules .= &file_contents ('ltlibrary',
The ltlibrary case also checks for library names.
Look for this line:
if ($onelib !~ /$libname_rx$/)
I think here we want to use `basename ($onelib)' just like you did for
the static library case.
adl> + if (!defined $directory_map{$directory}) {
Usually I put a space after `!'. (Akim doesn't, and I don't really
insist on this.)
`{' has to go on its own line though.
That is the coding style we use throughout.
adl> + if ($directory ne '.') {
adl> + return &require_build_directory ($directory);
adl> + } else {
adl> + return '';
Likewise here. `else' should also not appear on the same line as `}'.
If you make the above changes, you can just check it in without
resending.
Thanks!
Tom
- Re: allow convenient library in subdirectory, (continued)
- Re: allow convenient library in subdirectory, Tom Tromey, 2001/07/16
- Re: allow convenient library in subdirectory, Tim Van Holder, 2001/07/17
- Re: allow convenient library in subdirectory, Tom Tromey, 2001/07/17
- Re: allow convenient library in subdirectory, Tim Van Holder, 2001/07/17
- Re: allow convenient library in subdirectory, Tim Van Holder, 2001/07/17
- Re: allow convenient library in subdirectory, Akim Demaille, 2001/07/18
Re: allow convenient library in subdirectory, Tom Tromey, 2001/07/16
- Re: allow convenient library in subdirectory, Alexandre Duret-Lutz, 2001/07/17
- Re: allow convenient library in subdirectory, Tom Tromey, 2001/07/17
- Re: allow convenient library in subdirectory, Alexandre Duret-Lutz, 2001/07/18
- Re: allow convenient library in subdirectory,
Tom Tromey <=
- Re: allow convenient library in subdirectory, Alexandre Duret-Lutz, 2001/07/19
- Re: allow convenient library in subdirectory, Tom Tromey, 2001/07/19
- Re: allow convenient library in subdirectory, Tim Van Holder, 2001/07/19
- Re: allow convenient library in subdirectory, Tom Tromey, 2001/07/19
- Re: allow convenient library in subdirectory, Tim Van Holder, 2001/07/20
- Re: allow convenient library in subdirectory, Tom Tromey, 2001/07/20