[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: glr.c cleanup

From: Hans Aberg
Subject: Re: glr.c cleanup
Date: Wed, 7 Dec 2005 23:34:43 +0100

On 7 Dec 2005, at 21:57, Paul Hilfinger wrote:

I have some qualms about some of the renaming in that patch, e.g.,
renaming "yystack" to "yystackp".

This particular instance of Hungarian notation is not all that
objectionable, since it seems to be used fairly frequently in other
GNU code I've seen (including some of mine).

The "p" might be convenient if both variables are to be used side by side. However, also consider the multilingual issue: it won't be needed under C++. So in order to keep multilingual similarity, that suggests just naming it "yystack", without a "p". Names with a "p" added should then be reserved for C implementation variables, but not in the interface.

  Hans Aberg

reply via email to

[Prev in Thread] Current Thread [Next in Thread]