[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] {master} convert the conflict messages to a more bison-l
From: |
Paul Eggert |
Subject: |
Re: [PATCH 0/3] {master} convert the conflict messages to a more bison-like form |
Date: |
Mon, 24 Sep 2012 12:54:23 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 09/24/2012 12:40 AM, Akim Demaille wrote:
> #1
> foo.y: warning: 1 shift/reduce conflict [-Wconflicts-sr]
> foo.y: warning: 2 reduce/reduce conflicts [-Wconflicts-rr]
>
> bar.y: 1 shift/reduce conflict, expected 0
> bar.y: 2 reduce/reduce conflicts, expected 0
>
> Proposal #2:
> foo.y: warning: shift/reduce conflicts: 1 found [-Wconflicts-sr]
> foo.y: warning: reduce/reduce conflicts: 2 found [-Wconflicts-rr]
>
> bar.y: shift/reduce conflicts: 1 found, 2 expected
> bar.y: reduce/reduce conflicts: 2 found, 0 expected
Ignoring the problem of implementation and just thinking
about nice English, I prefer #1 for the first set of warnings
and #2 for the second set. That is:
foo.y: warning: 1 shift/reduce conflict [-Wconflicts-sr]
foo.y: warning: 2 reduce/reduce conflicts [-Wconflicts-rr]
bar.y: shift/reduce conflicts: 1 found, 2 expected
bar.y: reduce/reduce conflicts: 2 found, 0 expected
Prefixing the second set with "error:" would be fine.
- [PATCH 1/3] %expect-rr is for GLR only, (continued)
- [PATCH 1/3] %expect-rr is for GLR only, Akim Demaille, 2012/09/21
- [PATCH 2/3] conflicts: refactor the counting routines, Akim Demaille, 2012/09/21
- [PATCH 3/3] use the regular warning interface for s/r and r/r conflicts, Akim Demaille, 2012/09/21
- Re: [PATCH 0/3] {master} convert the conflict messages to a more bison-like form, Paul Eggert, 2012/09/21
- Re: [PATCH 0/3] {master} convert the conflict messages to a more bison-like form, Akim Demaille, 2012/09/23
- Re: [PATCH 0/3] {master} convert the conflict messages to a more bison-like form, Paul Eggert, 2012/09/23
- Re: [PATCH 0/3] {master} convert the conflict messages to a more bison-like form, Akim Demaille, 2012/09/23
- Re: [PATCH 0/3] {master} convert the conflict messages to a more bison-like form, Paul Eggert, 2012/09/23
- Re: [PATCH 0/3] {master} convert the conflict messages to a more bison-like form, Akim Demaille, 2012/09/24
- Re: [PATCH 0/3] {master} convert the conflict messages to a more bison-like form, Akim Demaille, 2012/09/24
- Re: [PATCH 0/3] {master} convert the conflict messages to a more bison-like form,
Paul Eggert <=
- Re: [PATCH 0/3] {master} convert the conflict messages to a more bison-like form, Akim Demaille, 2012/09/25