[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] grammar: free the association tracking graph

From: Akim Demaille
Subject: Re: [PATCH] grammar: free the association tracking graph
Date: Fri, 1 Feb 2013 09:16:48 +0100

Le 1 févr. 2013 à 00:59, Theophile Ranquet <address@hidden> a écrit :

> The graph introduced by Valentin wasn't free'd after use.
> * src/symtab.c (cleanup_assoc): New, clear the array of linked lists with...
> (cleanup_linkedlist): This, new.
> (print_precedence_warnings): Call cleanup_assoc when done.
> (print_assoc_warnings): Free used_assoc after use.

Fine.  I have a preference for assoc_free and linkedlist_free though.
I know Bison is not consistent in this regard, but I much prefer
having all the functions of module foo be named foo_*.  Eventually
I will rename the others too.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]