[Bug binutils/25180] Slowness in cplus_demangle()

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25180

--- Comment #7 from Nick Clifton <nickc at redhat dot com> ---
Hi Tim,

(In reply to Tim Rühsen from comment #6)
> the attached patch fixes the demangler slowness (see commit message for a
> description).

Did you run the libiberty testsuite to see if it introduces any new failures ?
Also it would be a good idea to run the g++ testsuite as well, just in case...

Given that you check for "d->d_counting > 1", would it make more sense to make
that field a boolean ?  If not, then should the limit be configurable somehow ?

Other than that though the patch looks fine to me, but of course I cannot
approve it.  Are you going to submit it to gcc-patches ?

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.