[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/11] quote consistently and make tests pass with new quotin

From: Akim Demaille
Subject: Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib
Date: Thu, 16 Feb 2012 17:20:29 +0100

Le 16 févr. 2012 à 16:56, Paul Eggert a écrit :

> On 02/16/2012 07:04 AM, Akim Demaille wrote:
>> gnulib forces the quote style on the program.
> I briefly looked at the patches you proposed in
> <http://lists.gnu.org/archive/html/bug-bison/2012-02/msg00003.html>
> and something along those lines sounds reasonable,
> though I confess that I still don't fully understand the issue.
> First question, though, is why the default quoting object
> needs to be malloc'ed -- can't it be in static storage?

Hi Paul,

The struct quoting_option is not exported, it is
internal to quotearg.c.  I would be happy to have
a static version of it, but that's not possible.
And exposing the struct in the .h might be too big
a change.

Really, I would *much* prefer not to introduce yet
another default quoting style and rely on a single
default quoting style: q = 0 in quotearg.  But then,
we have an expectation mismatch: quotearg is designed
with literal_quoting_style as default style, but
quote expects locale_quoting_style as default.  Fusing
both defaults might not be a good idea for most of
their users.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]