[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: "make check" failure in public-submodule-commit

From: Théophile Ranquet
Subject: Re: "make check" failure in public-submodule-commit
Date: Tue, 20 Nov 2012 12:13:24 +0100

Hi Stefano, hello Gnulibers,

2012/11/19 Stefano Lattarini <address@hidden>:
> $ git submodule --quiet foreach test '$(git rev-parse $sha1)'  = '$(git 
> merge-base origin $sha1)'

The quoting here seems a bit lacking. This is an issue with gnulib,
please see the attached patch for a fix. Note that the LRDE has filed
a global disclaimer for its staff for both Bison and Gnulib, so my
contributions can applied.

> [...]
> + eval test '$(git rev-parse $sha1)' = '$(git merge-base origin $sha1)'
> +++ git rev-parse daf7f8c02242c535d596231e2f655109b97fa2bc
> +++ git merge-base origin daf7f8c02242c535d596231e2f655109b97fa2bc
> fatal: Not a valid object name origin

This is something else, and I haven't been able to reproduce this bug.
Have you bootstrapped or run 'git fetch' in bison/gnulib/ recently?

> ++ test daf7f8c02242c535d596231e2f655109b97fa2bc =
> /usr/local/bleeding/libexec/git-core/git-submodule: line 445: test: 
> daf7f8c02242c535d596231e2f655109b97fa2bc: unary operator expected

This error is gratuitous, and related to the quoting issues mentioned above.


Attachment: 0001-maint.mk-avoid-gratuitous-failure.patch
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]