Re: coreutils-5.0.90 build feedback

[Jim Meyering]

Hi Nelson.
Thank you for all the testing!
The fixes for the first three are already checked in.

"Nelson H. F. Beebe" <address@hidden> wrote:
> Most of the coreutils-5.0.90 builds succeeded in at least one
> compilation environment on each system, but on most platforms, there
> was this single test failure:
>
> FAIL: remove

That was for tests/shred/remove.
Here's the patch:

2003-08-01  Jim Meyering  <address@hidden>

        * tests/shred/remove: Ensure that $? is 0 for the final `exit 0'.
        Otherwise, with at least the /bin/sh from HPUX 10.20,
        the trap code would end up converting that to exit 1 and thus an
        unexpected test failure.  Reported by Christian Krackowizer.

> There were build failures on some systems:
>
> ------------------------------------------------------------------------
> FreeBSD 4.4, FreeBSD 5.0, OpenBSD 3.2, Apple MacOS X
>
> gcc -DHAVE_CONFIG_H -I. -I. -I..  -I.. -I. -I../lib -I../lib 
> -I/usr/local/include
> -I/home/staff/computing/beebe/i386/local/include  -g -O2 -c `test -f 'nice.c' 
> || echo './'`nice.c
> In file included from nice.c:28:
> /usr/include/sys/resource.h:58: field `ru_utime' has incomplete type
> /usr/include/sys/resource.h:59: field `ru_stime' has incomplete type
> make[3]: *** [nice.o] Error 1

2003-08-02  Jim Meyering  <address@hidden>

        * src/nice.c [!NICE_PRIORITY]: Include <time.h> before <sys/resource.h>
        to avoid compilation error on Ultrix. Reported by Christian Krackowizer.

> ------------------------------------------------------------------------
> Sun Solaris 2.8 (SPARC), Sun Solaris 2.9 (SPARC and Intel x86)
> c89 -DHAVE_CONFIG_H -I. -I. -I..  -I.. -I. -I../lib -I../lib 
> -I/usr/local/include  -xO5 -dalign -xlibmil -xcg92 -xsafe=mem -c `test -f 
> 'date.c' || echo './'`date.c
> "../lib/stdbool.h", line 39: warning: _Bool is a keyword in ISO C99
> "../lib/stdbool.h", line 39: warning: _Bool is a keyword in ISO C99
> "../lib/posixtm.h", line 10: warning: _Bool is a keyword in ISO C99

2003-08-03  Paul Eggert  <address@hidden>

        * stdbool_.h (_Bool): Use a #define, not a typedef.




Here are the patches:

Index: tests/shred/remove
===================================================================
RCS file: /fetish/cu/tests/shred/remove,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -p -u -r1.9 -r1.10
--- tests/shred/remove  19 Jul 2003 11:47:17 -0000      1.9
+++ tests/shred/remove  1 Aug 2003 22:33:04 -0000       1.10
@@ -34,6 +34,6 @@ fail=0
 # This would take so long that it appears to infloop
 # when using version from fileutils-4.0k.
 # When the command completes, expect it to fail.
-shred -u $file > /dev/null 2>&1 && fail=1
+shred -u $file > /dev/null 2>&1 && fail=1 || :
 
 exit $fail
Index: src/nice.c
===================================================================
RCS file: /fetish/cu/src/nice.c,v
retrieving revision 1.67
retrieving revision 1.68
diff -u -p -u -r1.67 -r1.68
--- src/nice.c  23 Jul 2003 07:29:54 -0000      1.67
+++ src/nice.c  2 Aug 2003 20:39:06 -0000       1.68
@@ -25,6 +25,7 @@
 #include <getopt.h>
 #include <sys/types.h>
 #ifndef NICE_PRIORITY
+# include <time.h>
 # include <sys/resource.h>
 #endif
 
Index: lib/stdbool_.h
===================================================================
RCS file: /fetish/cu/lib/stdbool_.h,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -p -u -r1.1 -r1.2
--- lib/stdbool_.h      28 Jul 2003 08:35:50 -0000      1.1
+++ lib/stdbool_.h      3 Aug 2003 10:20:32 -0000       1.2
@@ -32,11 +32,13 @@
 /* For the sake of symbolic names in gdb, define true and false as
    enum constants.  However, do not define _Bool as the enum type,
    since the enum type might be compatible with unsigned int, whereas
-   _Bool must promote to int.  */
+   _Bool must promote to int.  Also, make _Bool a macro rather than a
+   typedef, to suppress warnings by the Sun Forte Developer 7 C
+   compiler that _Bool is a keyword in ISO C99.  */
 #ifndef __cplusplus
 # if address@hidden@
 enum { false = 0, true = 1 };
-typedef signed char _Bool;
+#  define _Bool signed char
 # endif
 #else
 typedef bool _Bool;