[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: base64 tool?
From: |
Jim Meyering |
Subject: |
Re: base64 tool? |
Date: |
Mon, 27 Feb 2006 12:11:20 +0100 |
Simon Josefsson <address@hidden> wrote:
> Here is an updated patch for Coreutils to provide the base64 command.
>
> I believe I have addressed all major comments given earlier, I'm
> Cc:ing all people who helped me, maybe they can help review it again.
>
> The lib/base64.? files are from gnulib.
>
> Warning: it has not been tested much at all!
Thank you!
I've made some minor changes e.g., to get past coreutils `make distcheck':
* src/base64.c: Don't include .h files already included by system.h:
<string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
Include "system.h" before the other lib/*.h header files.
Include <sys/types.h> before "system.h".
(wrap_write): Remove declaration of unused local, initial_column.
(wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
* README: Add base64 to the list.
Plus, I indented a few cpp directives in lib/base64.h,
to make them consistent with the first #define.
Would you please write a test script to go along with that?
I'd prefer that you model the new file, say tests/misc/base64,
after one of the existing ones that uses the Coreutils.pm module.
For example, tests/misc/expand is nice and small.