[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: base64 tool?
From: |
Jim Meyering |
Subject: |
Re: base64 tool? |
Date: |
Mon, 27 Feb 2006 13:21:35 +0100 |
Simon Josefsson <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>> Plus, I indented a few cpp directives in lib/base64.h,
>> to make them consistent with the first #define.
>
> I feeded gnulib with these.
Thanks!
>> Would you please write a test script to go along with that?
>> I'd prefer that you model the new file, say tests/misc/base64,
>> after one of the existing ones that uses the Coreutils.pm module.
>> For example, tests/misc/expand is nice and small.
>
> I forgot to include it, it was part of the first patch. Is the below
> sufficient?
It'd be nice if you would add examples demonstrating
use of the options. For example, I tried this:
$ seq 100|./base64 --wr=0
./base64: invalid wrap size: 0
[Exit 1]
A basic test might have caught that.
BTW, don't bother adding explicit tests of --decode.
If you don't do it first, I'll be happy to add code to derive
those tests from the others, just by swapping outputs and inputs.