[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new module fchdir

From: Bruno Haible
Subject: Re: new module fchdir
Date: Sun, 14 Jan 2007 14:55:28 +0100 (MET)
User-agent: KMail/1.5.4


Since there were no comments about the fchdir module, and I tested it on two
platforms, I committed it.

Paul Eggert wrote:
> I don't know what --avoid=canonicalize-lgpl is for.  Perhaps you can
> omit it.

It's because coreutils already uses the 'canonicalize' module, and 'fchdir'
depends on 'canonicalize-lgpl', which is the "small brother" of the
'canonicalize' module. coreutils doesn't need to include
lib/canonicalize-lgpl.c and m4/canonicalize-lgpl.m4.

coreutils builds fine with the appended patch.


2007-01-14  Bruno Haible  <address@hidden>

        * bootstrap.conf (avoided_gnulib_modules): Avoid canonicalize-lgpl,
        since we use canonicalize.
        (gnulib_modules): Add fchdir.
        * m4/jm-macros.m4 (coreutils_MACROS): Remove fchdir-stub.

diff --git a/bootstrap.conf b/bootstrap.conf
index 41d925f..73e7d49 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -1,6 +1,6 @@
 # Bootstrap configuration.
-# Copyright (C) 2006 Free Software Foundation, Inc.
+# Copyright (C) 2006, 2007 Free Software Foundation, Inc.
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -19,11 +19,12 @@
 # We don't need these modules, even though gnulib-tool mistakenly
-# includes them because of gettext dependencies.
+# includes them because of gettext and fchdir dependencies.
+       --avoid=canonicalize-lgpl
 # These modules are obsolete and can probably be removed soon,
@@ -41,8 +42,8 @@ gnulib_modules="
        c-strtold calloc canon-host canonicalize chown cloexec
        config-h configmake
        closeout cycle-check d-ino d-type diacrit dirfd dirname dup2
-       error euidaccess exclude exitfail fcntl fcntl-safer fdl file-type
-       fileblocks filemode filenamecat fnmatch-gnu fopen-safer
+       error euidaccess exclude exitfail fchdir fcntl fcntl-safer fdl
+       file-type fileblocks filemode filenamecat fnmatch-gnu fopen-safer
        fprintftime fsusage ftruncate fts getdate getgroups gethrxtime
        getline getloadavg getndelim2 getopt getpagesize getpass-gnu
        gettext gettime gettimeofday getugroups getusershell gnupload
diff --git a/m4/jm-macros.m4 b/m4/jm-macros.m4
index fe9970b..2595542 100644
--- a/m4/jm-macros.m4
+++ b/m4/jm-macros.m4
@@ -109,10 +109,6 @@ AC_DEFUN([coreutils_MACROS],
   if test $gl_cv_list_mounted_fs = yes && test $gl_cv_fs_space = yes; then
-  # If any of these functions don't exist (e.g. DJGPP 2.03),
-  # use the corresponding stub.
-  AC_CHECK_FUNC([fchdir], , [AC_LIBOBJ(fchdir-stub)])

reply via email to

[Prev in Thread] Current Thread [Next in Thread]