Re: [PATCH] avoid -Wsign-compare warnings

[Jim Meyering]

Pádraig Brady <address@hidden> wrote:
> I noticed Jim fixed a couple obvious
> issues highlighted by the -Wsigned-compare gcc option
> we were talking about a few days ago.
>
> The attached patch silences all other instances,
> so that this option may be used to help find these
> hard to spot errors, when they're introduced in future.
>
> Note this patch is just for comment at this stage.
> Also note it is not tested on 64 bit.

Hi Pádraig,

Thanks for working on reducing warnings.
It would indeed be nice to be able to enable more -W options.
However, in coreutils and gnulib, we've tried hard
over the years to avoid adding casts, so I'm very
leery of introducing new casts just to avoid what are
often false-alert warnings.

On the other hand, some of these changes look like obvious
and uncontroversial improvements, like the ones to od.c.

How about starting with a few smaller patches of that type?

Also, please include function names in ChangeLog/log entries.
I find it useful to use Ralf Wildenhues' vc-chlog program to
automatically generate the template from a modified git (or cvs,
svn, bz, hg-managed) working directory.
You can get the sources and build it from here:

  git clone git://git.sv.gnu.org/vc-dwim