Re: [Bug-cpio] cpio segfaulting when using -E

[Mike Frysinger]

On Thursday, September 02, 2010 16:25:57 Sergey Poznyakoff wrote:
> TBSDY <address@hidden> ha escrit:
> >    I'm running cpio 2.10
> >    the function call_arg_error(...) it never actually exits. I'm
> >    fairly certain that it's meant to be calling on
> >    call_arg_fatail(...).
> 
> Nope, that would break all other usages of this function. What *was*
> intended was that read_pattern_file should have called open_fatal
> instead, i.e.:
> 
> diff --git a/src/copyin.c b/src/copyin.c
> index d41b17f..22e33dc 100644
> --- a/src/copyin.c
> +++ b/src/copyin.c
> @@ -866,7 +866,7 @@ read_pattern_file ()
> 
>    pattern_fp = fopen (pattern_file_name, "r");
>    if (pattern_fp == NULL)
> -    open_error (pattern_file_name);
> +    open_fatal (pattern_file_name);
>    while (ds_fgetstr (pattern_fp, &pattern_name, '\n') != NULL)
>      {
>        if (new_num_patterns >= max_new_patterns)
> 
> which is the fix I'm going to push.

hasnt been pushed yet ?
-mike

signature.asc
Description: This is a digitally signed message part.