[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Commit/patch policy for bug-findutils

From: Eric Blake
Subject: Re: Commit/patch policy for bug-findutils
Date: Fri, 22 Jun 2007 06:16:10 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20070509 Thunderbird/ Mnenhy/

Hash: SHA1

According to James Youngman on 6/22/2007 2:26 AM:
>> Up to now, I haven't thought about it much.   I haven't been posting
>> patches to the list, but then there have been no other comitters.
> Would the members of the list prefer to see the patches?   Would you
> comment on them?   If the answer is yes, we should probably post
> matches to the list.  Supposing we have a policy of posting patches to
> the list before/after commit, do you think you would have the time to
> review them?

I don't know if we want one list or two.  For example, autoconf has
bug-autoconf and autoconf-patches, the former is where general bug reports
and savannah traffic are directed (and is the address published in
- --help), while the latter is reserved for patches or discussion thereof
(and is documented in HACKING, along with any other patch submission
policies).  Personally, I'm fine with either approach, but as patches tend
to be large, forming a new list for patch traffic may be wiser for those
only interested in tracking trends rather than actual patches.

> Would you prefer to review them before the commit (and hence protect
> the repository better against defects but be on the critical path) or
> after (and hence risk there being commits which you don't think are a
> good idea)?

I like the libtool-patches policy - post everything for review, and if you
have no comments (positive or negative) within three days, consider your
patch implicitly reviewed and approved for inclusion.  If someone pipes up
with approval, you can check in sooner, and if someone pipes up asking for
more time to complete their review, you respect their wishes.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


reply via email to

[Prev in Thread] Current Thread [Next in Thread]