[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #27213] consider_visiting: invalid assertion for FTS_NS due to acce
Martin von Gagern
[bug #27213] consider_visiting: invalid assertion for FTS_NS due to access permissions.
Wed, 26 Aug 2009 09:46:16 +0000
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:18.104.22.168) Gecko/20090812 Gentoo Firefox/3.5.2
Follow-up Comment #2, bug #27213 (project findutils):
I attached a patch that I believe should fix the issue. At least now "find
foo" does work, as does "find foo -ls".
With "works" I mean that it does print an error message and continue
traversal, instead of aborting due to a failed assertion.
1. Always print error message for FTS_NS. I can't imagine a case where you
wouldn't want to learn about a stat error, especially if this could prevent
you from knowing whether an inode is a directory or not.
2. assert stat.type == 0 in the case of FTS_NS. This is closer to the old
!state.have_type, so I guess that's what was meant.
3. Moved some post-condition assertions in get_info from the failure case to
the success case.
4. Added some comments, specially pointing out an issue with duplicate error
Those duplicate error messages should be avoided one day, but I'd rather have
duplicate error messages than failed assertions, so I don't think that the
introduction of these should block the application of this patch here.
Additional Item Attachment:
File name: 0001-Bug-27213-avoid-failed-assertions-for-non-executable.patch
Reply to this item at:
Nachricht geschickt von/durch Savannah