[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] find: use FTS_VERBATIM

From: Dmitry V. Levin
Subject: Re: [PATCH] find: use FTS_VERBATIM
Date: Sat, 15 Dec 2012 18:57:16 +0400

On Sat, Dec 15, 2012 at 02:33:09PM +0000, James Youngman wrote:
> On Sun, Nov 18, 2012 at 2:06 AM, Dmitry V. Levin wrote:
> > The recent change v0.0-7611-g3a9002d in gnulib that made fts_open strip
> > trailing slashes from input path names had a negative impact on
> > findutils that relies on the old fts_open behavior to implement POSIX
> > requirement that each path operand of the find utility shall be
> > evaluated unaltered as it was provided, including all trailing slash
> > characters.
> >
> > A new bit flag FTS_VERBATIM was added later as the option to disable
> > that stripping when it is not desirable.
> >
> > * gnulib: update to latest, to get FTS_VERBATIM support.
> > * find/ftsfind.c (ftsoptions): Set the FTS_VERBATIM bit.
> Thanks for this contribution.   Since you have already completed a
> copyright assignment for Findutils, I was able to simply apply your
> patch directly.


> I also needed to make an additional change to ensure that the
> regression test suite still passed after the gnulib update, since the
> gnulib update also contained a change to the semantics of the awk,
> gnu-awk and posix-awk regular expression types.

Oh, my bad, I made a similar change several months ago and I certainly
had to submit it, but somehow I didn't, and when this fts issue arose,
I failed to notice that.  Double fault from my side.  I'm sorry.


Attachment: pgpxB7XmU8AXg.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]