[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] [PATCH] Arrange caller of dfa and regex.

From: arnold
Subject: Re: [bug-gawk] [PATCH] Arrange caller of dfa and regex.
Date: Thu, 18 Aug 2016 09:25:16 -0600
User-agent: Heirloom mailx 12.4 7/29/08


Norihiro Tanaka <address@hidden> wrote:

> On Thu, 18 Aug 2016 07:51:48 -0600
> address@hidden wrote:
> > Thanks for the adjusted patch.
> > 
> > Why did you remove the saving and restoring of the final byte and
> > placing \n there? Is that no longer needed?
> > 
> > Thanks,
> > 
> > Arnold
> The saving and restoring of final byte is done in dfaexec() after commit
> bafa1341db643225c2421ecca90353e556dedae5.
> BTW, accoding to commit log, it seems that it came from gawk, but I do
> not know how to go upstream on commit log of gawk to 2010.

It was introduced into grep at the point where gawk's dfa.c was merged
back into the grep code base, but it's not a change I made, or I would
certainly have adjusted the code in gawk's re.c.

Gawk's git is not "complete" in that gawk used to be in private RCS, then
CVS; the gawk repo has complete releases checked in up to the point that
I switched to using it for development. That was around 2010.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]