[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gawk] [PATCH] gawk: use dfa matcher for regex with anchor
From: |
Norihiro Tanaka |
Subject: |
Re: [bug-gawk] [PATCH] gawk: use dfa matcher for regex with anchor |
Date: |
Thu, 22 Sep 2016 20:11:55 +0900 |
On Wed, 21 Sep 2016 02:15:26 -0600
address@hidden wrote:
> Hi. Thanks for this patch. I've applied it and pushed to the repo.
>
> For future reference, when adding tests, besides including the files in
> EXTRA_DIST in Makefile.am, you need to list the test's name in one of
> the macros that defines the categories of tests. I took care of that for
> you for this test. :-)
>
> Thanks for including a test case with your patch; that really helps improve
> the test suite and I appreciate it. I did verify that without the
> DFA_ANCHOR flag the test doesn't pass.
>
> And, thanks once more for caring about gawk in your work on dfa; I really
> appreciate it.
>
> Arnold
Thanks for reviewing and adjusting for the patch.
I did not realize that I do not need to add the entry to BASIC_TESTS
macro in test/Makefile.am and test/Maketests. I was aware that the test
has been passed with "ALL TESTS PASSED", actually it may have not been
run. (-_-;
Norihiro