[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] mktime UTC extremely slow (new in GAWK 4.2)

From: arnold
Subject: Re: [bug-gawk] mktime UTC extremely slow (new in GAWK 4.2)
Date: Wed, 12 Dec 2018 00:38:12 -0700
User-agent: Heirloom mailx 12.5 7/5/10

"Andrew J. Schorr" <address@hidden> wrote:

> Glad to hear that this patch solved your performance problem.
> Let's please keep the conversation on the mailing list so others
> have a chance to weigh in.
> Regards,
> Andy

Andy, I'm ok with the idea of the patch, but it needs to be integrated
into the code base a little differently.  The timegm function should
be put into a separate file in missing_d/timegm.c.  Then replace.c
should be adjusted to include it #ifndef HAVE_TIMEGM.  The code itself
should be adjusted to also check for mktime_gz, something like:

        time_t timegm(struct tm *tm)
        #ifdef HAVE_MKTIME_GZ
                // code here
        #error "neither timegm nor mktime_gz avaliable. sorry"

Can you do that and post the revised patch for review?

Much thanks!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]