[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] mktime UTC extremely slow (new in GAWK 4.2)

From: arnold
Subject: Re: [bug-gawk] mktime UTC extremely slow (new in GAWK 4.2)
Date: Wed, 12 Dec 2018 07:44:05 -0700
User-agent: Heirloom mailx 12.5 7/5/10

"Andrew J. Schorr" <address@hidden> wrote:

> On Wed, Dec 12, 2018 at 09:14:39AM -0500, Andrew J. Schorr wrote:
> > I guess you were thinking that a more general function could be useful.
> > Do you now think it's OK simply to implement timegm rather than
> > a more general mktime_tz function? The linux timegm man page
> > shows:
> >     setenv("TZ", "", 1);
> > whereas your code does:
> >     setenv("TZ", tzreq, 1);
> > and `tzreq' is set to "UTC+0". Do you want to continue to support
> > the more general case (which would explain why it's not in missing_d),
> > and if not, what's more portable for setting TZ: "" or "UTC+0"?
> Patch attached. Is this what you want?
> Regards,
> Andy

Except that I wold continue to use "UTC+0" which I suspect is
more portable.

If you make that change you can push it to gawk-4.2-stable. I'll
handle merging to the other branches.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]