[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: very wierd commit from emacs (or ntemacs) problem
From: |
Steve Kemp |
Subject: |
Re: very wierd commit from emacs (or ntemacs) problem |
Date: |
Fri, 4 May 2001 11:58:35 +0100 |
On Fri, 4 May 2001, Eli Zaretskii wrote:
> All the uses of a literal /bin/sh are bugs, so please report them to
> gnu.emacs.bug. Emacs should use the value of shell-file-name.
The following files appear to use /bin/sh inappropriately:
md5.el
terminal.el
feedmail.el
mh-comp.el
In addition to this pop3.el uses "shell-file-name", rather
than explicit-shell-file-name - I'm not sure if this is a bug
or not..
`tex-mode.el' also seems a little broken.
The attatched diffs fixup some of these issues.
Steve
---
# NT Emacs FAQ maintainer.
http://www.gnu.org/software/emacs/windows/faq.html
# All about Steve # And his GNU Software
http://www.steve.org.uk http://GNUSoftware.com
*** lisp\mail\feedmail.el-orig Fri May 4 10:45:20 2001
--- lisp\mail\feedmail.el Fri May 4 10:50:11 2001
***************
*** 1322,1328 ****
(set-buffer prepped)
(apply
'call-process-region
! (append (list (point-min) (point-max) "/bin/sh" nil errors-to nil "-c"
(format feedmail-binmail-template
(mapconcat 'identity addr-listoid " "))))))
--- 1322,1333 ----
(set-buffer prepped)
(apply
'call-process-region
! (append (list (point-min) (point-max)
! (or explicit-shell-file-name
! (getenv "ESHELL")
! (getenv "SHELL")
! "/bin/sh")
! nil errors-to nil "-c"
(format feedmail-binmail-template
(mapconcat 'identity addr-listoid " "))))))
*** lisp\mail\mh-comp.el-orig Fri May 4 10:45:20 2001
--- lisp\mail\mh-comp.el Fri May 4 10:51:57 2001
***************
*** 384,395 ****
(save-buffer)
(message "Redistributing...")
(if mh-redist-full-contents
! (call-process "/bin/sh" nil 0 nil "-c"
(format "mhdist=1 mhaltmsg=%s %s -push %s"
buffer-file-name
(expand-file-name mh-send-prog mh-progs)
buffer-file-name))
! (call-process "/bin/sh" nil 0 nil "-c"
(format "mhdist=1 mhaltmsg=%s mhannotate=1 %s -push %s"
(mh-msg-filename msg folder)
(expand-file-name mh-send-prog mh-progs)
--- 384,395 ----
(save-buffer)
(message "Redistributing...")
(if mh-redist-full-contents
! (call-process (or explicit-shell-file-name (getenv "ESHELL") (getenv
"SHELL") "/bin/sh") nil 0 nil "-c"
(format "mhdist=1 mhaltmsg=%s %s -push %s"
buffer-file-name
(expand-file-name mh-send-prog mh-progs)
buffer-file-name))
! (call-process (or explicit-shell-file-name (getenv "ESHELL") (getenv
"SHELL") "/bin/sh") nil 0 nil "-c"
(format "mhdist=1 mhaltmsg=%s mhannotate=1 %s -push %s"
(mh-msg-filename msg folder)
(expand-file-name mh-send-prog mh-progs)
*** lisp\mail\mh-utils.el-orig Fri May 4 10:45:20 2001
--- lisp\mail\mh-utils.el Fri May 4 10:52:29 2001
***************
*** 879,885 ****
(let ((status
(if env
;; the shell hacks necessary here shows just how broken Unix is
! (apply 'call-process "/bin/sh" nil t nil "-c"
(format "%s %s ${1+\"$@\"}"
env
(expand-file-name command mh-progs))
--- 879,885 ----
(let ((status
(if env
;; the shell hacks necessary here shows just how broken Unix is
! (apply 'call-process (or explicit-shell-file-name (getenv
"ESHELL") (getenv "SHELL") "/bin/sh") nil t nil "-c"
(format "%s %s ${1+\"$@\"}"
env
(expand-file-name command mh-progs))
*** lisp\terminal.el-orig Fri May 4 10:45:22 2001
--- lisp\terminal.el Fri May 4 10:47:39 2001
***************
*** 1139,1145 ****
process-environment)))))
(setq te-process
(start-process "terminal-emulator" (current-buffer)
! "/bin/sh" "-c"
;; Yuck!!! Start a shell to set some terminal
;; control characteristics. Then start the
;; "env" program to setup the terminal type
--- 1139,1148 ----
process-environment)))))
(setq te-process
(start-process "terminal-emulator" (current-buffer)
! (or explicit-shell-file-name
! (getenv "ESHELL")
! (getenv "SHELL")
! "/bin/sh") "-c"
;; Yuck!!! Start a shell to set some terminal
;; control characteristics. Then start the
;; "env" program to setup the terminal type
*** lisp\textmodes\tex-mode.el-orig Fri May 4 10:45:22 2001
--- lisp\textmodes\tex-mode.el Fri May 4 10:54:07 2001
***************
*** 995,1001 ****
(set-buffer
(make-comint
"tex-shell"
! (or tex-shell-file-name (getenv "ESHELL") (getenv "SHELL") "/bin/sh")
nil))
(let ((proc (get-process "tex-shell")))
(set-process-sentinel proc 'tex-shell-sentinel)
--- 995,1001 ----
(set-buffer
(make-comint
"tex-shell"
! (or tex-shell-file-name explicit-shell-file-name (getenv "ESHELL")
(getenv "SHELL") "/bin/sh")
nil))
(let ((proc (get-process "tex-shell")))
(set-process-sentinel proc 'tex-shell-sentinel)