[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Suspicious code in cmds.c
From: |
Christoph Conrad |
Subject: |
Re: Suspicious code in cmds.c |
Date: |
Tue, 20 Nov 2001 23:05:56 +0100 |
User-agent: |
Gnus/5.090004 (Oort Gnus v0.04) Emacs/21.1 (i586-pc-linux-gnu) |
In GNU Emacs 21.1.1 (i586-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
of 2001-10-22 on mutzel
configured using `configure --with-x'
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: german
locale-coding-system: nil
default-enable-multibyte-characters: nil
See the usage of modiff. It is set, but never changed. The last
statement in the following block is never executed. I see two
possibilities:
* Dead code. Survived some cleanup or refactoring.
* Code was redesigned and should work. Some error occurred.
I can't decide what's true.
,----
| {
| int modiff = MODIFF;
| Lisp_Object sym;
|
| sym = Fexpand_abbrev ();
|
| /* If we expanded an abbrev which has a hook,
| and the hook has a non-nil `no-self-insert' property,
| return right away--don't really self-insert. */
| if (! NILP (sym) && ! NILP (XSYMBOL (sym)->function)
| && SYMBOLP (XSYMBOL (sym)->function))
| {
| Lisp_Object prop;
| prop = Fget (XSYMBOL (sym)->function, intern ("no-self-insert"));
| if (! NILP (prop))
| return 1;
| }
|
| if (MODIFF != modiff)
| hairy = 2;
| }
`----
- Re: Suspicious code in cmds.c,
Christoph Conrad <=