Re: Suspicious code in cmds.c

[David Kastrup]

>>>>> "Christoph" == Christoph Conrad <christoph.conrad@gmx.de> writes:

 Christoph> Hello Miles,
 Christoph> you wrote:

 >> `modiff' won't change, but `MODIFF' could ...

 Christoph> ,----
 Christoph> | buffer.h: #define MODIFF (current_buffer->text->modiff)
 Christoph> `----

 Christoph> Oh yes, you're right. I Implicitly think of a constant
 Christoph> when seeing a symbol in C which is completely in capslock.

Same here.  In the interest of legibility, I'd recommend MODIFF taking
an argument of some sort, so that you'd have
MODIFF(current_buffer)
or at least
MODIFF()

Things like that are confusing.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum
Email: David.Kastrup@t-online.de