bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#4343: marked as done (comint-carriage-motion for async-shell-command


From: Emacs bug Tracking System
Subject: bug#4343: marked as done (comint-carriage-motion for async-shell-command)
Date: Thu, 10 Sep 2009 01:05:05 +0000

Your message dated Thu, 10 Sep 2009 03:55:21 +0300
with message-id <address@hidden>
and subject line Re: bug#4343: comint-carriage-motion for async-shell-command
has caused the Emacs bug report #4343,
regarding comint-carriage-motion for async-shell-command
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact address@hidden
immediately.)


-- 
4343: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4343
Emacs Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: comint-carriage-motion for async-shell-command Date: Sat, 05 Sep 2009 00:02:33 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu)
Often an asynchronous shell command run with M-& produces the output
that looks like garbage when programs use carriage control characters ^M
to display progress with percentages.

Even the `compile' command is better in this regard because its
`compilation-filter' handles carriage motion using the function
`comint-carriage-motion'.

The following patch does the same for asynchronous commands in
`shell-command'.  It seems it was intended to do this anyway because
`*Async Shell Command*' uses `shell-mode'.  But `shell-mode' doesn't set
the filter that processes carriage control characters.  It is the `shell'
command that sets the filter via `comint-exec' before enabling `shell-mode'.
So it's necessary to set the filter explicitly in `shell-command'
after enabling `shell-mode':

Index: lisp/simple.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/simple.el,v
retrieving revision 1.1008
diff -u -r1.1008 simple.el
--- lisp/simple.el      28 Aug 2009 04:21:17 -0000      1.1008
+++ lisp/simple.el      4 Sep 2009 21:02:21 -0000
@@ -2214,7 +2220,11 @@
                  (setq mode-line-process '(":%s"))
                  (require 'shell) (shell-mode)
                  (set-process-sentinel proc 'shell-command-sentinel)
+                 ;; Use the comint filter for proper handling of carriage 
motion
+                 ;; (see `comint-inhibit-carriage-motion'),.
+                 (set-process-filter proc 'comint-output-filter)
                  ))
            (shell-command-on-region (point) (point) command
                                     output-buffer nil error-buffer)))))))

-- 
Juri Linkov
http://www.jurta.org/emacs/



--- End Message ---
--- Begin Message --- Subject: Re: bug#4343: comint-carriage-motion for async-shell-command Date: Thu, 10 Sep 2009 03:55:21 +0300 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu)
>> Other than setting `comint-output-filter', `comint-exec' also starts
>> a process.  But starting a process is not necessary in `shell-command'
>> that starts it explicitly.
>
> OK, then.
>
>>> And try and move this into a new function `comint-setup-process' which
>>> both compile.el and M-& could then use?
>
>> They can't be merged because `compilation-filter' runs a compile-specific
>> hook `compilation-filter-hook'.
>
> Too bad.  Please install your patch, then.

Done.

-- 
Juri Linkov
http://www.jurta.org/emacs/

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]