bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be call


From: Michael Heerdegen
Subject: bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel"
Date: Thu, 15 Aug 2013 16:43:13 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Stefan Monnier <address@hidden> writes:

> > 1. The Elisp manual says nothing about this.  Is this something new?
>
> No.
>
> > 2. What is wrong with code such as this at top level?
>
> Nothing.  But most of the cases I bumped into (all of which have been
> fixed now, AFAIK) were cases where the author had confused
> make-local-variable and make-variable-buffer-local.

Maybe

  "Warning: `make-variable-buffer-local' not called at toplevel"

would have the same learning experience, without saying "should be...",
which is wrong and confusing to people who know what they're doing.


Michael.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]