[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#18006: Simplify via set_binary_mode

From: Paul Eggert
Subject: bug#18006: Simplify via set_binary_mode
Date: Mon, 14 Jul 2014 13:16:06 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

Eli Zaretskii wrote:
Otherwise, the patch looks good to me.

Thanks; I installed it after fixing things up as per your comments.

Your explanation of _fmode led me to find a minor porting bug. Fx_load_color_file [!HAVE_X_WINDOWS] uses fopen with "rt"; unlike "rb" this isn't specified by POSIX and a web search suggests that it does fail on a few older platforms. Emacs no longer modifies _fmode so "r" should suffice now anyway. Also, there are two other places where some "rt"-related simplifications can be done. Proposed further patch attached.

Attachment: binary-io.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]