[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#23484: 25.1.50; undo doesn't work properly in xref-query-replace-in-

From: Dmitry Gutov
Subject: bug#23484: 25.1.50; undo doesn't work properly in xref-query-replace-in-results
Date: Mon, 9 May 2016 23:10:15 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1

On 05/09/2016 11:01 PM, Juri Linkov wrote:

Why not using an original search string instead of ‘.*’ thus avoiding
tricks with isearch-filter-predicate/replace-re-search-function?

A few reasons:

- We don't actually save it.
- Being able to replace _any_ regexp inside the matches is a feature (though maybe it's not going to be very popular).
- We're replacing the given list of matches, not all regexp occurrences.

perform-replace will have no problem finding the same matches
as found by xref.

That's not true, xref is not limited by Grep is regexp searching in the ways that its results are found.

E.g. xref-find-references is not necessarily the result of a regexp search. The default implementation is a bit basic, but different backends can implement smarter logic (so that the search takes into account the context at point, and only returns the uses of the local variable within its scope, or only method calls, etc). We'll still want to be able to replace them.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]