[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24745: Acknowledgement (25.1.50; whitespace.el: fix beginning/end of

From: Reuben Thomas
Subject: bug#24745: Acknowledgement (25.1.50; whitespace.el: fix beginning/end of buffer checks)
Date: Fri, 21 Oct 2016 15:38:44 +0100

I have expanded my work on whitespace.el to address other problems.

First, I revised my previous patch, which had an error in the new version of whitespace-empty-at-eob-regexp.

Next, I removed some duplicate documentation from the Commentary section: it was already out of date in one or two places, and it duplicated information readily available in docstrings.

Next, I fixed some problems with whitespace-space-after-tab-regexp.

Finally, I fixed whitespace-report-region to respect user settings: it no longer returns true when the region has a problem not covered by whitespace-style; however, it still diagnoses and reports all possible problems.

There's one more problem with whitespace-report-region I would like to fix, which is that currently the force parameter changes whitespace-style globally; it should, I believe, only change it for the duration of the function.

I'd appreciate some review of these patches (all against current git master).



Attachment: 0001-whitespace-fix-bob-eob-checks.patch
Description: Text Data

Attachment: 0002-whitespace.el-remove-duplicate-documentation.patch
Description: Text Data

Attachment: 0003-whitespace.el-fix-whitespace-space-after-tab-regexp.patch
Description: Text Data

Attachment: 0004-whitespace.el-make-whitespace-report-region-respect-.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]