[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow

From: Juri Linkov
Subject: bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow
Date: Mon, 12 Feb 2018 23:50:55 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)

>> In the command line of git version 1.9.1 running git log on two files
>> (command line copied from *Messages* when vc-command-messages is t)
>>   git --no-pager log --no-color --follow -n 2000 -- vc-dispatcher.el 
>> vc-git.el
>> fails with the error:
>>   usage: git logs can only follow renames on one pathname at a time
>> whereas running git on one directory ‘vc’
>>   git --no-pager log --no-color --follow -n 2000 -- vc
>> doesn't fail.  Although I can't confirm the correctness of the output log:
>> it seems the option ‘--follow’ has no effect on directories.
> Even if it's true, it means --follow doesn't do any harm when invoked
> on directories, and we shouldn't disallow that.

I don't know the reason why disallowing directories was implemented
in the first place.  Maybe ‘git log --follow’ failed on directories
in some older git versions?  Wouldn't it be safer to leave the code
that checks for directories and doesn't add ‘--follow’ for this case?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]