bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow


From: Eli Zaretskii
Subject: bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow
Date: Tue, 13 Feb 2018 07:40:27 +0200

> From: Juri Linkov <address@hidden>
> Cc: address@hidden,  address@hidden
> Date: Mon, 12 Feb 2018 23:50:55 +0200
> 
> > Even if it's true, it means --follow doesn't do any harm when invoked
> > on directories, and we shouldn't disallow that.
> 
> I don't know the reason why disallowing directories was implemented
> in the first place.  Maybe ‘git log --follow’ failed on directories
> in some older git versions?  Wouldn't it be safer to leave the code
> that checks for directories and doesn't add ‘--follow’ for this case?

Sorry, I was confused and thought that you also added the
non-directory restriction.  I agree that we should not modify the code
that checks for directories, certainly not on the release branch.

Thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]