bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#35141: Add a default action to erc-desktop-notifications to switch t


From: Basil L. Contovounesios
Subject: bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer
Date: Fri, 05 Apr 2019 12:22:41 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Alex Murray <address@hidden> writes:

> Thanks for the review - see attached for an updated version based on your 
> feedback.

I just tried byte-compiling the patched file and got the following
warning:

  ELC      erc/erc-desktop-notifications.elc
  In toplevel form:
  erc/erc-desktop-notifications.el:74:1:
  Warning: Unused lexical argument ‘proc’

Since this arises because of lexical-binding, could you please also add
an underscore to the name of the PROC argument in
erc-notifications-PRIVMSG?

Otherwise LGTM, but we'll have to wait a few days to give others a
chance to comment.

Thanks,

-- 
Basil





reply via email to

[Prev in Thread] Current Thread [Next in Thread]