[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#39902: 28.0.50; Marking in dired with active region

From: Drew Adams
Subject: bug#39902: 28.0.50; Marking in dired with active region
Date: Mon, 23 Mar 2020 08:20:53 -0700 (PDT)

> > The docstring of `dired-mark-inclusive' should be enhanced a bit I
> > think.  You could add one sentence about what "inclusive" means, and
> > another saying that other (un-)marking commands are also covered.
> I enhanced the docstring, renamed to `dired-mark-region',
> and pushed to master.
> The default behavior was unchanged since it's consistent with
> marking without region. But this is not my personal preference.
> I have dozens of customized options in my init file, even for features
> that I implemented, my customization still differs from default values
> that make sense for most users.  The default value of the new option
> `dired-mark-region' could be changed too in case more people
> will demand this.

Thank you for changing the name of the option.  I meant
to say something about that, but forgot.

I don't know what you have as the doc string (I don't
have the diff/patch), but here's my opinion about the
option description:

It's _not_ good to express it in the terms you described:
as being about including or excluding the limit at the
region end.  That's not it at all, IMO.

This should be expressed in terms of the behavior being
either line-oriented (as is nearly all of Dired) or
file-name oriented.

Put differently, the description should say that the
two choices are these:

1. Mark if _any_ part of the file's line is selected.
2. Mark if _all_ of the file name is selected.

(Where "selected" means "in the region".)

That's much clearer, I think.  It's expressed in terms
of what users do and see.  Either you need to select
some part of the line or you need to select all of the
file name.  What could be simpler?

(Anyway, I'm glad we've more or less reached agreement.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]