[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone han
From: |
Lars Ingebrigtsen |
Subject: |
bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling |
Date: |
Wed, 12 Aug 2020 15:12:27 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
thunk2@arcor.de (Thomas Plass) writes:
> Attached is an updated ZIP containing the respun patch and the
> unmodified samples. The patch is against
> https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/calendar/icalendar.el
> blob: d76c11050312b4a04ac1cbda436b3c08fc6f2cc5
>
> Hopefully, this is OK as it is.
It would be better to add the test cases in the test/data directory and
add the tests as code to icalendar-tests.el...
> : Thomas, could you please provide the expected results for the test files,
> : one for each ics file? Thanks!
>
> Well, the expected result depends on:
>
> - The local timezone of the person running the code. Where I'm
> sitting, it is November 3, 2018 20:15h for all samples.
(etc)
This is why the test cases should bind the time zone to whatever it is
it's testing -- that way we can easily ensure that the code continues to
work.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
- bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling, Lars Ingebrigtsen, 2020/08/10
- bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling, Ulf Jasper, 2020/08/10
- bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling, Eli Zaretskii, 2020/08/10
- bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling, Thomas Plass, 2020/08/10
- bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling, Lars Ingebrigtsen, 2020/08/11
- bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling, Ulf Jasper, 2020/08/11
- bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling, Lars Ingebrigtsen, 2020/08/11
- bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling, Ulf Jasper, 2020/08/11
- bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling, Thomas Plass, 2020/08/12
- bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling,
Lars Ingebrigtsen <=
- bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling, Thomas Plass, 2020/08/12
- bug#34315: [PATCH] icalendar.el: DURATION fix + more robust timezone handling, Ulf Jasper, 2020/08/12