bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered

[Andrii Kolomoiets]

Pankaj Jangid <pankaj@codeisgreat.org> writes:

> Andrii Kolomoiets <andreyk.mad@gmail.com> writes:
>
>> See docstring of the `vc-deduce-fileset`:
>>
>>   If the current buffer is in `vc-dir' or Dired mode, FILESET is the
>>   list of marked files, or the current directory if no files are
>>   marked.
>
> Got it. But the second clause `or the current directory if no files are
> marked' is not accurate. Because in that case `i' (vc-register) works if
> the point is on an untracked item.

Indeed.

> Wait... is `vc-deduce-fileset' relevant for `vc-register'? I don't
> know.

Yes.  `vc-register` is calling `vc-deduce-fileset` right after `interactive`.

>> Including file name in the "File already registered" message may help to
>> understand whats going on though.
>
> This could be a long list. We can just say "Marked file(s) already
> registered".

Files in the list are checked one by one and error is returned for the
first registered file.  IMO filename will fit well in the error message.