bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already


From: Dmitry Gutov
Subject: bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered
Date: Sun, 8 Nov 2020 14:11:26 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

Version: 28.1

On 08.11.2020 04:58, Pankaj Jangid wrote:
Dmitry Gutov <dgutov@yandex.ru> writes:

Does this work for y'all?

diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index 8def7da377..32664bcd25 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -1391,7 +1391,7 @@ vc-register
        (unless fname
          (setq fname buffer-file-name))
        (when (vc-call-backend backend 'registered fname)
-         (error "This file is already registered"))
+         (error "This file is already registered: %s" fname))
        ;; Watch out for new buffers of size 0: the corresponding file
        ;; does not exist yet, even though buffer-modified-p is nil.
        (when bname

Yes. This is fine. User can then take action accordingly.

Very good, pushed to master.

Regarding the other concern: vc-register's docstring says:

  Register into a version control system.
If VC-FILESET is given, register the files in that fileset.
Otherwise register the current file.

so the behavior seems correct.

Let us know if there's anything still amiss, though.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]