[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62234: Toolbar does not work properly (with Emacs 29 or 30)
From: |
Daniel Martín |
Subject: |
bug#62234: Toolbar does not work properly (with Emacs 29 or 30) |
Date: |
Sat, 18 Mar 2023 11:25:51 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) |
Po Lu <luangruo@yahoo.com> writes:
>> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem
>> +{
>> + return [toolbarItem isEnabled];
>> +}
>> +
>
> This does no harm on GNUstep. However, please indent with two spaces,
> and place spaces after -, :, and ):
>
> - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem
> {
> return [toolbarItem isEnabled];
> }
>
> Otherwise, LGTM. Thanks.
OK, I've attached a new version of the patch. Konrad, could you check
if with this patch the Emacs toolbar works as you expect? Thanks.
0001-Fix-toolbar-item-validation-in-the-NS-port.patch
Description: Text Data
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Konrad Podczeck, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Eli Zaretskii, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Konrad Podczeck, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Eli Zaretskii, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Daniel Martín, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Eli Zaretskii, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Po Lu, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Daniel Martín, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Po Lu, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30),
Daniel Martín <=
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Konrad Podczeck, 2023/03/18
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Eli Zaretskii, 2023/03/23
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Konrad Podczeck, 2023/03/23
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Konrad Podczeck, 2023/03/17