[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62234: Toolbar does not work properly (with Emacs 29 or 30)
From: |
Eli Zaretskii |
Subject: |
bug#62234: Toolbar does not work properly (with Emacs 29 or 30) |
Date: |
Thu, 23 Mar 2023 10:10:10 +0200 |
> From: Daniel Martín <mardani29@yahoo.es>
> Cc: Eli Zaretskii <eliz@gnu.org>, 62234@debbugs.gnu.org, Konrad Podczeck
> <konrad.podczeck@univie.ac.at>
> Date: Sat, 18 Mar 2023 11:25:51 +0100
>
> Po Lu <luangruo@yahoo.com> writes:
>
> >> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem
> >> +{
> >> + return [toolbarItem isEnabled];
> >> +}
> >> +
> >
> > This does no harm on GNUstep. However, please indent with two spaces,
> > and place spaces after -, :, and ):
> >
> > - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem
> > {
> > return [toolbarItem isEnabled];
> > }
> >
> > Otherwise, LGTM. Thanks.
>
> OK, I've attached a new version of the patch. Konrad, could you check
> if with this patch the Emacs toolbar works as you expect? Thanks.
Thanks, installed on the emacs-29 branch, and closing the bug.
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), (continued)
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Eli Zaretskii, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Konrad Podczeck, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Eli Zaretskii, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Daniel Martín, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Eli Zaretskii, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Po Lu, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Daniel Martín, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Po Lu, 2023/03/17
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Daniel Martín, 2023/03/18
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Konrad Podczeck, 2023/03/18
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30),
Eli Zaretskii <=
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Konrad Podczeck, 2023/03/23
- bug#62234: Toolbar does not work properly (with Emacs 29 or 30), Konrad Podczeck, 2023/03/17