|
From: | Mohsin Kaleem |
Subject: | bug#62994: [PATCH 1/3] Add face definitions for more underline styles |
Date: | Fri, 21 Apr 2023 17:08:39 +0100 |
Eli Zaretskii <eliz@gnu.org> writes: > Is it really necessary to change the numerical value of > FACE_UNDER_WAVE? Can it be left at its original value? If consistency with Smulx is desirable then I think it is. Otherwise when we populate the escape sequence for the underline we'll need to map from the face underline style to the sequence underline style. Reordering like this makes them match so we don't have to do any extra processing later, but if preferable I can retain the original order and add a helper function to map to the sequence value. -- Mohsin Kaleem
[Prev in Thread] | Current Thread | [Next in Thread] |