bug-gnu-utils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Some grep 2.5e issues


From: Bernhard Rosenkraenzer
Subject: Some grep 2.5e issues
Date: Sun, 13 May 2001 16:22:35 +0200 (CEST)

Hi,
I've just tried out grep 2.5e (on a post-7.1 snapshot of Red Hat Linux).

There are a couple of things that should IMO be changed:

1. PCRE detection isn't working right. Red Hat Linux (and probably others)
   place pcre.h in /usr/include/pcre rather than straight /usr/include
   (or /usr/local/include); grep doesn't catch this.
   Since PCRE comes with pcre-config (that takes care of just that), it's
   simple to fix; Patch attached as attachment #1

2. Since some people will definitely alias grep="grep --color" sooner or
   later (and start wondering why the output of "grep foo /bar |less"
   looks weird), I think --color should be handled the way it is in ls:
   Allow an optional parameter (--color={never,always,auto}) and default
   to --color=auto if the user specifies just "--color".
   Patch attached as attachment #2 (includes patch to docs)

3. This is a matter of taste, but I think the blinking of grep --color
   output is not a very good idea; Attachment #3 switches this over to
   "normal" red.

4. README-alpha states "This is a test release of GNU tar" and tells
   people to report bugs to bugs-tar. I don't presume that's a feature. ;)
   Fixed by attachment #4

Other than that, it seems to work really well.

LLaP
bero

Attachment: grep-2.5e-pcre.patch
Description: PCRE detection

Attachment: grep-2.5e-color.patch
Description: color patch

Attachment: grep-2.5e-noblink.patch
Description: noblink patch

Attachment: grep-2.5e-readme.patch
Description: readme patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]