[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
sharutils-4.3.60 "make check" umask problem and version mismatch
From: |
Paul Eggert |
Subject: |
sharutils-4.3.60 "make check" umask problem and version mismatch |
Date: |
Sun, 30 Jun 2002 22:50:47 -0700 (PDT) |
"make check" failed as follows:
2c2
< # This is a shell archive (produced by GNU sharutils 4.3.53).
---
> # This is a shell archive (produced by GNU sharutils 4.3.60).
9c9
< # 15 -rw-r--r-- shar-1.in
---
> # 15 -rw-rw-r-- shar-1.in
83c83
< chmod 0644 'shar-1.in' ||
---
> chmod 0664 'shar-1.in' ||
FAIL: shar-1
Apparently shar1.ok was built with sharutils 4.3.53? The fix for that
is to build it with the latest version, I guess. Here's a fix for
the permissions mismatch:
2002-06-30 Paul Eggert <address@hidden>
* tests/Makefile.am (shar-1.ok): Use a umask of 022, to avoid
spurious report of a test failure when installers have other
uamsks.
* tests/shar-1: Likewise.
diff -pru sharutils-4.3.60/tests/Makefile.am
sharutils-4.3.60-fix/tests/Makefile.am
--- sharutils-4.3.60/tests/Makefile.am 2002-06-26 13:34:25.000000000 -0700
+++ sharutils-4.3.60-fix/tests/Makefile.am 2002-06-30 22:40:33.568862000
-0700
@@ -23,7 +23,7 @@ TESTS_ENVIRONMENT = top_srcdir=$(top_src
EXTRA_DIST = $(TESTS) testdata shar-1.ok
shar-1.ok: ../configure.ac
- echo "This is a test" > shar-1.in
+ umask 022 && echo "This is a test" > shar-1.in
PATH=../src:$$PATH shar -f shar-1.in | \
sed -e 6,10d -e 's/_sh[0-9][0-9][0-9][0-9][0-9]/_shPID/' \
-e 's/-am ..........//' \
diff -pru sharutils-4.3.60/tests/shar-1 sharutils-4.3.60-fix/tests/shar-1
--- sharutils-4.3.60/tests/shar-1 2002-06-26 13:33:56.000000000 -0700
+++ sharutils-4.3.60-fix/tests/shar-1 2002-06-30 22:42:45.598495000 -0700
@@ -8,7 +8,7 @@ current_dir="`pwd`"
trap 'rm -fr $tmpfiles' 1 2 3 15
tmpfiles="shar-1.in shar-1.shar"
-echo "This is a test" > shar-1.in
+(umask 22 && echo "This is a test" > shar-1.in)
: ${SHAR=shar}
${SHAR} -f $current_dir/shar-1.in > shar-1.shar 2> /dev/null
result=$?