[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnubg] Coding Styles - Indentation / Tabs / Spaces

From: Philippe Michel
Subject: Re: [Bug-gnubg] Coding Styles - Indentation / Tabs / Spaces
Date: Sat, 3 Nov 2012 23:06:51 +0100 (CET)
User-agent: Alpine 2.00 (BSF 1167 2008-08-23)

On Fri, 26 Oct 2012, Michael Petch wrote:

How do people feel about reformatting the code?

I agree that it would be useful

What style is preferred?

I mostly agree with yours and Joseph's suggestions except when it comes to avoiding blank lines.

Should we consider reformatting all the code at once or module by module
as we work on them?

Module by module seems preferable, but we would have to decide on what indent parameters list to use, assuming this is standard. Mine has :

     indent [input-file [output-file]] [-bacc | -nbacc] [-bad | -nbad]
            [-bap | -nbap] [-ei | -ei] [-eei | -eei] [-bbb | -nbbb]
            [-bc | -nbc] [-bl] [-br] [-cn] [-cdn] [-cdb | -ncdb] [-ce | -nce]
            [-cin] [-clin] [-dn] [-din] [-fbs | -nfbs] [-fc1 | -nfc1]
            [-fcb | -nfcb] [-in] [-ip | -nip] [-ln] [-lcn] [-ldin]
            [-lp | -nlp] [-npro] [-pcs | -npcs] [-psl | -npsl] [-sc | -nsc]
            [-sob | -nsob] [-st] [-ta] [-troff] [-ut | -nut] [-v | -nv]

with -br being your -kr. If this is the only discrepancy or there is enough of a common subset, it should be ok.

If we do source reformatting I'd suggest if we take a file out, we do
the source formatting first, commit it back into revision control, and
then make code modifications.

Yes, of course.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]