[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

GNUmakefile: git-version-gen, maintainer-check, install

From: Joel E. Denny
Subject: GNUmakefile: git-version-gen, maintainer-check, install
Date: Sat, 9 Aug 2008 19:16:08 -0400 (EDT)


I frequently run make maintainer-check during Bison development.  I don't 
see a need to update VERSION every time.  Is the following patch 
acceptable, or would it be better to rename maintainer-check* to something 
else in Bison?

--- ../../gnulib/top/GNUmakefile        2008-08-06 18:31:57.000000000 -0400
+++ ./GNUmakefile       2008-08-09 19:03:00.000000000 -0400
@@ -53,7 +53,7 @@
 _have-git-version-gen := \
   $(shell test -f $(srcdir)/$(_build-aux)/git-version-gen && echo yes)
 ifeq ($(_have-git-version-gen)0,yes$(MAKELEVEL))
-  _is-dist-target = $(filter-out %clean, \
+  _is-dist-target = $(filter-out maintainer-check% %clean, \
     $(filter maintainer-% dist% alpha beta major,$(MAKECMDGOALS)))
   _is-install-target = $(filter-out %check, $(filter install%,$(MAKECMDGOALS)))
   ifneq (,$(_is-dist-target)$(_is-install-target))

Also, I noticed that the stale version warning for make install always 
scrolls out of the terminal window.  I never notice it unless I'm looking 
for it, so it's not doing me much good.  Is there any way to print it 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]