[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] use unlocked io in getdelim

From: Simon Josefsson
Subject: Re: [PATCH] use unlocked io in getdelim
Date: Wed, 27 Aug 2008 16:49:47 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

>> However, to deal with 2) and 3) I would prefer if the current code stays
>> around.  It could be moved to a 'getline-portable' module.
> For now, what do you think about the other patch?  It does already
> provide an interesting performance increase.

It is OK with me, please push it.

I do feel that the entire unlocked IO feature is poorly implemented in
the way that it requires changes to all code that wants to use it, but I
don't have a solution for that.  Can't you set some global flag that
makes all getc calls unlocked?  Instead of modifying all code to call
getc_unlocked instead of getc.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]