[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] use unlocked io in getdelim

From: Simon Josefsson
Subject: Re: [PATCH] use unlocked io in getdelim
Date: Wed, 27 Aug 2008 17:21:11 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

>> I do feel that the entire unlocked IO feature is poorly implemented in
>> the way that it requires changes to all code that wants to use it, but I
>> don't have a solution for that.  Can't you set some global flag that
>> makes all getc calls unlocked?  Instead of modifying all code to call
>> getc_unlocked instead of getc.
> You can add #include "unlocked-io.h" to your config.h using AH_VERBATIM.

It still requires changes to code like this to make use of it, doesn't
it?  That feels like an unclean design to me, but it is not important.

>  However, notice that the patch provides the performance increase even
> if *not* using unlocked-io.h.

I hadn't realized that.  Thanks for pushing it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]