[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add optional silent-rules support

From: Sergey Poznyakoff
Subject: Re: [PATCH] Add optional silent-rules support
Date: Thu, 21 May 2009 12:58:15 +0300

Hi Ralf,

> Can gnulib-tool create
>   target1 target2 ... \
>     targetN : prereq1 ... \
>               prereqN ; rule-command
> rules?

Well, quick grep through modules/* shows that so far no module
generates such rules.  But in theory it is possible.  I'll take
it into account, then.

> Shouldn't that be
>       if (match($1, /^@/) && !match($1, /address@hidden/))
> so that it won't treat
>       @ command
> wrongly?

Yes, indeed.  Nice catch.

> Also, this ignores the other possible command prefixes,
> '-' and '+', which can be mixed and matched together with '@' in any
> order.  But that probably doesn't happen in the files this targets.

Yes, so far it does not.  But probably it should be addressed, too.

> IIUC then you remove any extra indentation; why not something like
>               sub(/^\t[\t ]*/, "&$(AM_V_GEN)")
>               print

Yes, that's a better approach.  Thanks.

> FWIW the awk script is not portable to ancient awk, such as found on
> Solaris.

Hmm, but why?  I didn't use any GNU awk extensions, did I?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]