|
From: | Sam Steingold |
Subject: | Re: arg-nonnull.h & warn-on-use.h in build-aux |
Date: | Tue, 16 Mar 2010 15:01:12 -0400 |
User-agent: | Thunderbird 2.0.0.22 (X11/20090625) |
Eric Blake wrote:
On 03/08/2010 11:34 AM, Sam Steingold wrote:Sam Steingold wrote:Alternatively, I would be reasonably happy with sed -i -e 's/_GL_ARG_NONNULL/GL_ARG_NONNULL/' arg-nonnull.h sed -i -e 's/_GL_WARN_ON_USE/GL_WARN_ON_USE/' warn-on-use.h similar to GL_LINK_WARNING in link-warning.h.So, any chance the constants in arg-nonnull.h & warn-on-use.h could be renamed to lose the leading underscore? note that the only other build-aux header, link-warning.h, defines macros _without_ the leading underscore, so it seems to make sense for the new headers in build-aux to lose the leading underscore too.I'm still hoping Bruno will step in and help in this thread.
obviously, he won't. are we stuck forever?
link-warning.h was created first, before we realized that the use of a leading GL_ might lead to conflicts with other packages. The use of a leading _GL_ is intended to mark items that are specifically in gnulib's namespace. As to whether the template files live in build-aux or get moved to lib, Bruno needs to answer why link-warning.h was originally stuck in build-aux rather than lib. For arg-nonnull and warn-on-use, they are just following precedent. If we do any motion, all three files should be handled the same way.
absolutely!
[Prev in Thread] | Current Thread | [Next in Thread] |