[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] forkpty, openpty: split functions into new modules
From: |
Simon Josefsson |
Subject: |
Re: [PATCH 2/3] forkpty, openpty: split functions into new modules |
Date: |
Fri, 19 Mar 2010 10:07:38 +0100 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) |
I like these changes -- I think I mentioned that approach earlier when
adding the pty module, but before we had replacement functions for
forkpty/openpty in progress, the separation is kind of unnecessary.
Let's hope we'll have replacement functions soon after this. Feel free
to push your changes.
>> I don't understand two things here:
>> - Why does 'forkpty' depend on 'openpty'?
>
> I guess it doesn't have to. It's just that for now, test-forkpty.c
> tests both interfaces.
It may be cleanest to split the test modules too, so there is one
test-forkpty.c and test-openpty.c.
>> - Since forkpty.m4 is used for both 'forkpty' and 'openpty', it is
>> asymetric
>> and a bit misleading to call it 'forkpty.m4'. Why not call it 'pty.m4'?
>
> Sure; I named it forkpty.m4 to avoid confusion with the fact that I just
> renamed pty.m4 -> pty_h.m4 in the previous patch. But pty.m4 for both
> forkpty and openpty makes sense. I'll post a respin of the patches,
> incorporating your comments, and restart the review clock.
Thanks,
Simon
- ‘pty’ module fails on FreeBSD 7.2, Ludovic Courtès, 2010/03/16
- Re: ‘pty’ module fails on FreeBSD 7.2, Ralf Wildenhues, 2010/03/16
- Re: ‘pty’ module fails on FreeBSD 7.2, Ludovic Courtès, 2010/03/17
- Re: ‘pty’ module fails on FreeBSD 7.2, Eric Blake, 2010/03/17
- [PATCH 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Bruno Haible, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules,
Simon Josefsson <=
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/19
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Bruno Haible, 2010/03/19
- [PATCH 1/3] pty: improve replacement header, Eric Blake, 2010/03/18
- Re: [PATCH 1/3] pty: improve replacement header, Bruno Haible, 2010/03/18
- Re: [PATCH 1/3] pty: improve replacement header, Bruno Haible, 2010/03/19
- [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Eric Blake, 2010/03/18
- Re: [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Bruno Haible, 2010/03/18
- Re: [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Eric Blake, 2010/03/18
- [PATCHv2 1/3] pty: improve replacement header, Eric Blake, 2010/03/18
- [PATCHv2 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/18