[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype
From: |
Eric Blake |
Subject: |
Re: [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype |
Date: |
Thu, 18 Mar 2010 19:48:08 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b1 Thunderbird/3.0.3 |
On 03/18/2010 07:40 PM, Bruno Haible wrote:
>> + AC_CHECK_DECLS([forkpty],,, [[
>> +#if HAVE_UTIL_H
>> +# include <util.h>
>> +#endif
>> +#if HAVE_LIBUTIL_H
>> +# include <libutil.h>
>> +#endif
>> +]])
>
> Why does this set of includes not contain
> #if HAVE_PTY_H
> # include <pty.h>
> #endif
> ? Isn't it needed on glibc systems?
When the code was part of gl_PTY, it did not need the check (it was
inside a block that already checked for $ac_cv_header_pty_h = no;
therefore, the assumption was that if you have <pty.h>, you don't have
to check for the decl). But now that it is independently checked, you
are correct that I should also be conditionally including <pty.h>.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, (continued)
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Bruno Haible, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Simon Josefsson, 2010/03/19
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/19
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Bruno Haible, 2010/03/19
- [PATCH 1/3] pty: improve replacement header, Eric Blake, 2010/03/18
- Re: [PATCH 1/3] pty: improve replacement header, Bruno Haible, 2010/03/18
- Re: [PATCH 1/3] pty: improve replacement header, Bruno Haible, 2010/03/19
- [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Eric Blake, 2010/03/18
- Re: [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Bruno Haible, 2010/03/18
- Re: [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype,
Eric Blake <=
- [PATCHv2 1/3] pty: improve replacement header, Eric Blake, 2010/03/18
- [PATCHv2 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/18
- Re: [PATCHv2 2/3] forkpty, openpty: split functions into new modules, Bruno Haible, 2010/03/21
- Re: [PATCHv2 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/22
- [PATCHv2 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Eric Blake, 2010/03/18
- Re: [PATCHv2 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Bruno Haible, 2010/03/19