[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHv2 2/3] forkpty, openpty: split functions into new modules

From: Eric Blake
Subject: Re: [PATCHv2 2/3] forkpty, openpty: split functions into new modules
Date: Mon, 22 Mar 2010 09:23:33 -0600
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b1 Thunderbird/3.0.3

On 03/21/2010 05:56 PM, Bruno Haible wrote:
> As an addendum to this patch, let's make the naming of macros more consistent:
> 2010-03-21  Bruno Haible  <address@hidden>
>       pty: Consistent macro naming.
>       * m4/pty_h.m4 (gl_PTY_H): Renamed from gl_PTY.
>       * m4/pty.m4 (gl_FORKPTY, gl_OPENPTY): Update.
>       * modules/pty (configure.ac): Update.

Thanks; I debated about that when doing the patches, but chickened out.
 Then again, doing it separately is nice, because it is always easier to
review small incremental patches that only do one thing, rather than
mega-patches that do it all in one fell swoop.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]